Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Services tests from Linux JS Tests Job and Separate Workflow for flaky Selenium Tests #105

Merged
merged 4 commits into from
Jun 4, 2022

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented May 26, 2022

Update: 06/03/22

  • Originally, this PR attempted to pin jupyter_client <7.x to fix the services (macOS) Linux JS Tests job.
    However, while pinning jupyter_client <7.x allows the macOS services tests consistently pass locally, the CI test results are not consistent. That change has been discarded.

  • Currently, the services (Ubuntu and macOS) tests are being excluded and are to be further addressed in a separate issue.

  • Lastly, creating a separate workflow for flaky selenium tests


Using jupyter_client 7.x dependency leads to different behavior.
The execution of the following code in a cell, results in only two of the four expected events

import os
from ipykernel.connect import get_connection_file
with open(get_connection_file(), 'w') as f:
       f.write('garbage')
       os._exit(1)

The two events trigged: 'kernel_restarting.Kernel', 'kernel_autorestarting.Kernel'
The two events not triggered: 'kernel_killed.Session', 'kernel_dead.Kernel'

@RRosio RRosio changed the title pinning jupyter_client version <7.x Partial Fix for Linux JS Tests services (macos) and exclude services (ubuntu) from workflow Jun 3, 2022
@RRosio RRosio added the bug Something isn't working label Jun 3, 2022
@RRosio RRosio changed the title Partial Fix for Linux JS Tests services (macos) and exclude services (ubuntu) from workflow Exclude Services tests from Linux JS Tests Job and Separate Workflow for flaky Selenium Tests Jun 4, 2022
@RRosio RRosio marked this pull request as ready for review June 4, 2022 08:21
@echarles
Copy link
Member

echarles commented Jun 4, 2022

Sounds like this PR does the job

Linux JS Tests / build (ubuntu, base) (pull_request) Successful in 3m
Flaky Selenium Tests / build (ubuntu, 3.8) (pull_request) Successful in 6m

@RRosio Is this ready for review?

@RRosio
Copy link
Collaborator Author

RRosio commented Jun 4, 2022

@echarles Yes please! Yes, this PR does those jobs! There are three builds tested under the Flaky Selenium Tests job, then the Selenium Tests job was modified to exclude those three builds that would be tested under the flaky workflow. Lastly the Linux JS Tests job was modified to exclude the services tests for both macOS and Ubuntu.
The three builds under Flaky Selenium Tests (ubuntu, 3.8),(macos, 3.7) and (macos, 3.9) are currently all passing too

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx @RRosio

@echarles echarles merged commit 69ca14b into jupyter:main Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants